<html>
<head><meta charset="utf-8"><title>subtree sync causes rustc issues to be closed · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/subtree.20sync.20causes.20rustc.20issues.20to.20be.20closed.html">subtree sync causes rustc issues to be closed</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="231946399"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/subtree%20sync%20causes%20rustc%20issues%20to%20be%20closed/near/231946399" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/subtree.20sync.20causes.20rustc.20issues.20to.20be.20closed.html#231946399">(Mar 26 2021 at 11:03)</a>:</h4>
<p>So apparently when a clippy commit message has something like <code>fixes #xyz</code> in it and it gets pulled into the rustc repo, github will automatically close rustc issue #xyz because it does not know that the commit message does refer to a different tree :(</p>
<p><a href="https://github.com/rust-lang/rust/issues/70651#issuecomment-808070630">https://github.com/rust-lang/rust/issues/70651#issuecomment-808070630</a></p>



<a name="231946554"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/subtree%20sync%20causes%20rustc%20issues%20to%20be%20closed/near/231946554" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/subtree.20sync.20causes.20rustc.20issues.20to.20be.20closed.html#231946554">(Mar 26 2021 at 11:04)</a>:</h4>
<p>We could probably fix this by enforcing full paths to our issues in the commit messages like <a href="https://github.com/rust-lang/rust-clippy/issue/xyz">https://github.com/rust-lang/rust-clippy/issue/xyz</a>  but I'm not sure how much PITA that will be when enforced via ci..?</p>



<a name="231946667"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/subtree%20sync%20causes%20rustc%20issues%20to%20be%20closed/near/231946667" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/subtree.20sync.20causes.20rustc.20issues.20to.20be.20closed.html#231946667">(Mar 26 2021 at 11:05)</a>:</h4>
<p>perhaps we could somehow make bors automatically fix <a href="https://github.com/rust-lang/rust/issues/123">#123</a> links to full urls when merging or something like that</p>



<a name="231966698"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/subtree%20sync%20causes%20rustc%20issues%20to%20be%20closed/near/231966698" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/subtree.20sync.20causes.20rustc.20issues.20to.20be.20closed.html#231966698">(Mar 26 2021 at 13:46)</a>:</h4>
<p>See <a href="https://github.com/rust-lang/rust/issues/70651">#70651</a> for more discussion about this. bors sanitizing PR bodies sounds like a good solution to me (removing GitHub keywords)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>